Cleanup redis cluster error handling #1109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing our error handling we've settled on the approach of:
.context()
functionality to report chains of errorsOther(anyhow::Error)
variant.However this redis code was written a long time ago and doesnt follow that, so I am updating it to do so in this PR.
TransformError::IO
etc are not used for any logic so I have instead combined them intoTransformError::Other
Same with
ConnectionError
I created a transparentConnectionError::Other
variant for themThere was a duplicate
tracing::warn
in many cases so I removed it and let the caller deal with warning when it needs to.