Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test configs folder cleanup #1305

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

conorbros
Copy link
Member

No description provided.

@rukai
Copy link
Member

rukai commented Aug 23, 2023

Thanks for taking this on!

@conorbros conorbros force-pushed the test-configs-folder-cleanup branch 3 times, most recently from 3f15695 to 154db59 Compare August 29, 2023 03:22
@conorbros conorbros marked this pull request as ready for review August 29, 2023 05:08
@conorbros conorbros requested a review from rukai August 29, 2023 06:20
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, lets land this!

@rukai
Copy link
Member

rukai commented Aug 29, 2023

Context for the next reviewer:
We started putting our new test configs in per protocol folders recently.
This pr changes our old test configs to follow this new format.

@conorbros conorbros merged commit 952501b into shotover:main Aug 29, 2023
37 checks passed
@conorbros conorbros deleted the test-configs-folder-cleanup branch August 29, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants