Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windsock docker fixes #1317

Merged
merged 2 commits into from
Aug 31, 2023
Merged

windsock docker fixes #1317

merged 2 commits into from
Aug 31, 2023

Conversation

rukai
Copy link
Member

@rukai rukai commented Aug 31, 2023 •
edited
Loading

Once it was checked in and I could use it I discovered a few bugs:

  • We need to do rm -rf to handle the case where the directory doesnt exist
  • We need to copy results to the host so that we can access the bench results from there.

@rukai rukai requested a review from conorbros August 31, 2023 05:56
@rukai rukai enabled auto-merge (squash) August 31, 2023 10:07
@rukai rukai merged commit e6eb8b1 into shotover:main Aug 31, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjrolo cjrolo cjrolo approved these changes

@conorbros conorbros conorbros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rukai @cjrolo @conorbros