Tee changes #1320
Merged
Tee changes #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will update the docs too before merging. |
|
What benefit did you get from setting the fail message on |
rukai
reviewed
Aug 31, 2023
rukai
reviewed
Aug 31, 2023
conorbros
force-pushed
the
tee-changes
branch
from
7a37040
to
b427243
Compare
rukai
reviewed
Sep 5, 2023
conorbros
force-pushed
the
tee-changes
branch
from
2360a78
to
dc0a7be
Compare
I would still like to know the use case for this before proceeding. |
conorbros
force-pushed
the
tee-changes
branch
from
1bb00a4
to
24ba51d
Compare
|
Oops, I thought I had removed that. I thought it would be useful for debugging different subchains but not that much. |
rukai
approved these changes
Sep 13, 2023
cjrolo
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes that I found myself wanting while developing OpenSearch.
- The ability to set the fail message onDebugReturnerLogMismatchbehaviour forTee