Windsock: redis benches - generate topology.yaml #1332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked on:#1334
#1335
#1336
This PR begins a refactor for windsock to define its topology.yaml files using the config structs from shotover and serializing them to yaml.
This allows us to programmatically create the configuration we need for windsock.
The advantages of this are:
However this comes at the cost of introducing a lot of complexity where previously it was simple but just repetitive.
I currently think that we should never use this topology.yaml generation for our integration tests because having hardcoded yaml files is easier to understand, and allows us to properly integration test shotover as average users will have to write these files by hand.