Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rstest_reuse #1345

Merged
merged 2 commits into from
Sep 22, 2023
Merged

add rstest_reuse #1345

merged 2 commits into from
Sep 22, 2023

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Sep 21, 2023

Small helper library that removes duplications from our rstest setup for the Cassandra integration tests.

@github-actions
Copy link

0 benchmark regressed. 2 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/6258635367

  1 (1.00%) low mild
  4 (4.00%) high mild
  1 (1.00%) high severe
transform/redis_cluster_ports_rewrite
                        time:   [1.0573 µs 1.0716 µs 1.0860 µs]
                        change: [-34.521% -28.149% -24.130%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild
transform/cassandra_request_throttling_unparsed
                        time:   [774.97 ns 784.02 ns 795.11 ns]
                        change: [-24.654% -23.498% -22.189%] (p = 0.00 < 0.05)
                        Performance has improved.

shotover-proxy/tests/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@conorbros conorbros merged commit 540132b into shotover:main Sep 22, 2023
38 checks passed
@conorbros conorbros deleted the cassandra-int-tests branch September 22, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants