Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter AllowList & DenyList #1346

Merged
merged 7 commits into from
Sep 27, 2023
Merged

Filter AllowList & DenyList #1346

merged 7 commits into from
Sep 27, 2023

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Sep 22, 2023

Expands Filter transform functionality to let you specify either an allow list or deny list of messages types.

@conorbros conorbros marked this pull request as ready for review September 26, 2023 03:57
@rukai
Copy link
Member

rukai commented Sep 27, 2023

This seems like a nice improvement to the API!
It is both more flexible and makes the transform self documenting as it has AllowList or DenyList written right there, removing ambiguity about whether the filter is an allow or deny kind of filter.

The one last thing we need is an entry in the changelog describing how to upgrade to the new format. No need to describe how to use the new features. Just need to give the equivalent of the old usage in the new usage.

changelog.md Outdated Show resolved Hide resolved
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@conorbros conorbros merged commit 22f27be into shotover:main Sep 27, 2023
38 checks passed
@conorbros conorbros deleted the filter branch September 27, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants