Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windsock-cloud-runner: misc fixes #1354

Merged
merged 2 commits into from
Oct 9, 2023
Merged

windsock-cloud-runner: misc fixes #1354

merged 2 commits into from
Oct 9, 2023

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 6, 2023 •
edited
Loading

  • The escape function will add quotes if needed. e.g. foo bar becomes 'foo bar'. However "" becomes which fails to parse when running something like --results-by-tags "" as that just becomes --results-by-tags and --results-by-tags needs to have a single argument.
  • The windsock_data directory wont exist if its the first time running, so we have to ignore failures.

@rukai rukai force-pushed the fix_windsock_directory_delete branch from 510ab50 to cb8617f Compare October 6, 2023 02:30
@rukai rukai changed the title windsock: fix directory delete that may not exist windsock-cloud-runner: misc fixes Oct 6, 2023
@rukai rukai requested a review from conorbros October 6, 2023 05:37
@rukai rukai merged commit 9ce3b35 into shotover:main Oct 9, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjrolo cjrolo cjrolo approved these changes

@conorbros conorbros conorbros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rukai @cjrolo @conorbros