windsock-cloud-docker: cleanup running processes when killed #1358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor windsock-cloud-docker so that it cleans up the in progress cargo command.
Its very common to want to kill cargo while its building if I change my mind.
Currently when I do that to windsock-cloud-docker it leaves a stray cargo process running in the background which will:
This is quite problematic.
To fix this I:
Doing this without async is quite difficult as we would need to refactor commands to be nonblocking, better to just go async at that point than manually dealing with non blocking commands.
The actual logic of setting up the container and running windsock remains the same, its just all asyncified.
This PR also removes an unrelated stray TODO which had already been addressed in a previous PR.