Update aws-throwaway + aws-sdk-kms #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
aws_throwaway_update
branch
from
a9ff353
to
8b1aada
Compare
|
Why not do a new release for aws-throwaway? |
|
I have a few reasons but they arent very good ones, I'll make a release. |
rukai
force-pushed
the
aws_throwaway_update
branch
from
8b1aada
to
ce01689
Compare
rukai
changed the title
conorbros
approved these changes
Oct 18, 2023
cjrolo
reviewed
Oct 20, 2023
cjrolo
reviewed
Oct 20, 2023
cjrolo
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to make use of the placement group changes in aws-throwaway.
The code changes needed here all stem from: shotover/aws-throwaway#14