Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI workflow to ensure docker image continues to build and run #1366

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Add CI workflow to ensure docker image continues to build and run #1366

merged 3 commits into from
Nov 13, 2023

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 2, 2023

Blocked on #1364

@rukai
Copy link
Member Author

rukai commented Nov 2, 2023

sweet, this demonstrates that this test would have caught the issue fixed by 1364
image

@rukai rukai marked this pull request as ready for review November 2, 2023 21:05
@rukai rukai requested a review from conorbros November 10, 2023 04:00
@rukai rukai enabled auto-merge (squash) November 13, 2023 10:33
@rukai rukai merged commit d9a6091 into shotover:main Nov 13, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjrolo cjrolo cjrolo approved these changes

@conorbros conorbros conorbros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rukai @cjrolo @conorbros