Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our release process is very brittle as we do not exercise it in any way during development.
cargo-dist
did not exist when we first set this process up but it does now and it solves this problem by being batteries included and testing the release process during development: https://github.com/axodotdev/cargo-distSo we should swap to it in the future.
However, for now I am just quickly fixing the bug so we can complete the half-complete release process.
There are a few issues:
cargo test
- the project doesnt even supportcargo test
anymore, instead we rely oncargo nextest
. Just delete it, no need to be testing everything at this pointshotover
in the root of the repo, there is already a folder with that name in the root now. So lets instead use the directory of the script as the root to avoid the collision.I verified these changes fix the issue by running
build_release.sh
on my local machine.I removed the musl building dead code, there are better ways of achieving that these days anyway.