Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shotover release process #1389

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix shotover release process #1389

merged 2 commits into from
Dec 11, 2023

Conversation

rukai
Copy link
Member

@rukai rukai commented Dec 8, 2023

Our release process is very brittle as we do not exercise it in any way during development.

cargo-dist did not exist when we first set this process up but it does now and it solves this problem by being batteries included and testing the release process during development: https://github.com/axodotdev/cargo-dist
So we should swap to it in the future.

However, for now I am just quickly fixing the bug so we can complete the half-complete release process.
There are a few issues:

  • we ran cargo test - the project doesnt even support cargo test anymore, instead we rely on cargo nextest. Just delete it, no need to be testing everything at this point
  • It creates a folder called shotover in the root of the repo, there is already a folder with that name in the root now. So lets instead use the directory of the script as the root to avoid the collision.

I verified these changes fix the issue by running build_release.sh on my local machine.

I removed the musl building dead code, there are better ways of achieving that these days anyway.

@rukai rukai requested a review from conorbros December 8, 2023 04:16
@rukai rukai enabled auto-merge (squash) December 11, 2023 22:19
@rukai rukai merged commit 9ab82f7 into shotover:main Dec 11, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants