Implement kafka controller routing #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some requests need to be routed to a specific kafka broker known as the "controller broker".
However currently we never perform that routing.
This results in messages like CreateTopic having 2/3 chance of failing when sent to a 3 node kafka cluster.
This PR fixes that failure by:
To ensure all the admin requests work, I have added an integration test which exercises most of it.
I've left a few bits of the integration test as TODOs, they can be addressed later.
Surprisingly CreateTopic is the only request I've seen so far that needs to be routed to the controller broker.