Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud shotover metrics #1449

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

rukai
Copy link
Member

@rukai rukai commented Feb 1, 2024

I needed to fix two things to get shotover_metrics working on cloud benches:

  • Use the connect_ip to fetch the metrics from instead of the private ip. connect_ip will automatically select the private or public ip depending on how aws-throwaway was configured. Public is used when the bencher is on your local machine private is used when the bencher is within EC2.
  • expose port 9001 to the internet via expose_ports_to_internet builder method.

@rukai rukai force-pushed the fix_cloud_shotover_metrics branch 5 times, most recently from 03ebb33 to 6d6479a Compare February 4, 2024 23:37
@rukai rukai marked this pull request as ready for review February 5, 2024 01:16
@rukai rukai merged commit 15e030c into shotover:main Feb 6, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants