Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split drop out of kafka codec benchmarks #1467

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Split drop out of kafka codec benchmarks #1467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d518c9f
Split drop out of kafka codec benchmarks
rukai Feb 9, 2024
a091a8d
Merge branch 'main' into split_drop_out_of_kafka_codec_benchmarks
rukai Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 36 additions & 37 deletions shotover/benches/benches/codec/kafka.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ fn criterion_benchmark(c: &mut Criterion) {
{
let mut input = BytesMut::new();
input.extend_from_slice(message);
group.bench_function(format!("decode_{file_name}"), |b| {
group.bench_function(format!("decode_{file_name}_create"), |b| {
b.iter_batched(
|| {
(
Expand All @@ -39,12 +39,35 @@ fn criterion_benchmark(c: &mut Criterion) {
input.clone(),
)
},
|((mut decoder, _encoder), mut input)| {
let mut result = decoder.decode(&mut input).unwrap().unwrap();
for message in &mut result {
message.frame();
}
black_box(result)
|((mut decoder, encoder), mut input)| {
let mut message =
decoder.decode(&mut input).unwrap().unwrap().pop().unwrap();
message.frame();

// avoid measuring any drops
(decoder, encoder, input, message)
},
BatchSize::SmallInput,
)
});
group.bench_function(format!("decode_{file_name}_drop"), |b| {
b.iter_batched(
|| {
// Recreate everything from scratch to ensure that we dont have any `Bytes` references held onto preventing a full drop
let (mut decoder, encoder) =
KafkaCodecBuilder::new(Direction::Source, "kafka".to_owned()).build();
let mut input = input.clone();
let mut message =
decoder.decode(&mut input).unwrap().unwrap().pop().unwrap();
message.frame();
assert!(decoder.decode(&mut input).unwrap().is_none());
(decoder, encoder, message)
},
|(decoder, encoder, message)| {
std::mem::drop(message);

// avoid measuring any drops other than the message
(decoder, encoder)
},
BatchSize::SmallInput,
)
Expand Down Expand Up @@ -72,43 +95,18 @@ fn criterion_benchmark(c: &mut Criterion) {
messages.clone(),
)
},
|((_decoder, mut encoder), messages)| {
|((decoder, mut encoder), messages)| {
let mut bytes = BytesMut::new();
encoder.encode(messages, &mut bytes).unwrap();
black_box(bytes)
std::mem::drop(black_box(bytes));
(encoder, decoder)
},
BatchSize::SmallInput,
)
});
}
}

{
let mut input = BytesMut::new();
for (message, _) in KAFKA_REQUESTS {
input.extend_from_slice(message);
}
group.bench_function("decode_all", |b| {
b.iter_batched(
|| {
(
// recreate codec since it is stateful
KafkaCodecBuilder::new(Direction::Source, "kafka".to_owned()).build(),
input.clone(),
)
},
|((mut decoder, _encoder), mut input)| {
let mut result = decoder.decode(&mut input).unwrap().unwrap();
for message in &mut result {
message.frame();
}
black_box(result)
},
BatchSize::SmallInput,
)
});
}

{
let mut messages = vec![];
for (message, _) in KAFKA_REQUESTS {
Expand All @@ -134,10 +132,11 @@ fn criterion_benchmark(c: &mut Criterion) {
messages.clone(),
)
},
|((_decoder, mut encoder), messages)| {
|((decoder, mut encoder), messages)| {
let mut bytes = BytesMut::new();
encoder.encode(messages, &mut bytes).unwrap();
black_box(bytes)
std::mem::drop(black_box(bytes));
(encoder, decoder)
},
BatchSize::SmallInput,
)
Expand Down
Loading