Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra 5 functions #1474

Merged
merged 10 commits into from
Feb 14, 2024
Merged

Cassandra 5 functions #1474

merged 10 commits into from
Feb 14, 2024

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Feb 12, 2024

The only changes are to shotover-proxy/tests/cassandra_int_tests/functions.rs. The rest is from the cluster tests PR.

Javascript functions have been deprecated in Cassandra 5 so I have switched our function tests to Java.

@conorbros conorbros requested a review from rukai February 12, 2024 06:48
@conorbros conorbros marked this pull request as ready for review February 12, 2024 06:48
Copy link

4 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7868145645

Found 13 outliers among 100 measurements (13.00%)
  6 (6.00%) high mild
  7 (7.00%) high severe
cassandra_codec/encode_system.local_query_v5_no_compression
                        time:   [1.3750 µs 1.4206 µs 1.4639 µs]
                        change: [+30.371% +36.893% +43.551%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
Found 4 outliers among 100 measurements (4.00%)
  1 (1.00%) high mild
  3 (3.00%) high severe
cassandra_codec/encode_system.local_query_v5_lz4_compression
                        time:   [1.6817 µs 1.7090 µs 1.7345 µs]
                        change: [+35.414% +39.937% +46.958%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe
cassandra_codec/encode_system.local_result_v5_no_compression
                        time:   [38.628 µs 39.941 µs 40.978 µs]
                        change: [+58.181% +67.380% +76.042%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe
cassandra_codec/encode_system.local_result_v5_lz4_compression
                        time:   [47.556 µs 48.920 µs 50.104 µs]
                        change: [+20.979% +24.175% +27.571%] (p = 0.00 < 0.05)
                        Performance has regressed.

@rukai
Copy link
Member

rukai commented Feb 12, 2024

the microbenchmarks have been noisier since #1459 and your PR clearly wouldnt affect them so dont worry about it.

@rukai
Copy link
Member

rukai commented Feb 12, 2024

#1468 seems to be a prereq for this PR so I've marked this as draft.

@rukai rukai marked this pull request as draft February 12, 2024 22:20
@conorbros conorbros marked this pull request as ready for review February 14, 2024 02:23
Copy link

1 benchmark regressed. 2 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7895625309

                        time:   [502.22 ns 526.83 ns 548.41 ns]
                        change: [-9.9571% -6.0249% -2.5078%] (p = 0.00 < 0.05)
                        Change within noise threshold.
kafka_codec/decode_request_list_offsets_create
                        time:   [649.36 ns 663.40 ns 677.13 ns]
                        change: [+23.158% +26.470% +29.697%] (p = 0.00 < 0.05)
                        Performance has regressed.
                        No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
kafka_codec/decode_request_fetch_create
                        time:   [501.30 ns 506.73 ns 512.72 ns]
                        change: [-32.358% -30.305% -28.068%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 15 outliers among 100 measurements (15.00%)
  3 (3.00%) high mild
  12 (12.00%) high severe
kafka_codec/decode_request_fetch_drop
                        time:   [234.04 ns 235.69 ns 237.68 ns]
                        change: [-53.025% -48.911% -44.365%] (p = 0.00 < 0.05)
                        Performance has improved.

Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get to run the whole suite now, nice!
Using java over javascript makes sense to me, no point in testing deprecated features IMO.

@rukai rukai merged commit 5443175 into shotover:main Feb 14, 2024
40 checks passed
@conorbros conorbros deleted the cassandra-5-functions branch February 14, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants