Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka message parsing #1499

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Kafka message parsing #1499

merged 3 commits into from
Feb 25, 2024

Conversation

conorbros
Copy link
Member

No description provided.

Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Thanks for solving this so we dont have to worry about adding anymore in the future!

@rukai
Copy link
Member

rukai commented Feb 23, 2024

Woah, looks like this PR increases the size of the binary by 4MB probably still worth it though.

@rukai
Copy link
Member

rukai commented Feb 23, 2024

Oh, this PR adds 3 minutes release build time in CI, maybe we should at least measure how long a release build takes locally before we merge.

Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should measure effect on release build time locally before merging.
Maybe we can alter the kafka-parser crate to improve build times or maybe removing the use of generics here would help

Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the build time locally.
On my machine, this PR increases the time to run cargo build --release -p shotover-proxy --no-default-features --features kafka from 1min 15s to 1min 32s

This is an unfortunate regression, but we do want to be parsing every kafka message, so lets land it and possibly investigate ways to speed it up in the future.
And at the very least we now have the protocol feature flags so this build time regression will only affect kafka development.

@rukai rukai merged commit 0661bec into shotover:main Feb 25, 2024
40 checks passed
@conorbros conorbros deleted the kafka-message-parsing branch May 23, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants