Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java kafka driver backend to kafka integration tests #1509

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Feb 29, 2024

progress towards #1500

This PR splits our kafka driver abstraction up so that it supports the old CPP driver and additionally supports the java kafka driver.
So far it only implements a tiny amount of the the java driver to demonstrate the functionality while setting up the abstractions we will use and keeping the PR size manageable.

In order to use j4rs in our tests we need to include the target/debug/jassets directory in the nextest archive used for distributing builds across many CI machines.
nextest does not currently support that so I have:

The PR is not as big as it appears, the admin function has been moved unchanged into cpp.rs so that we can reimplement it within java.rs

@rukai rukai force-pushed the java_kafka_driver branch 6 times, most recently from 1b03696 to bbbe16e Compare March 1, 2024 04:06
@rukai rukai marked this pull request as ready for review March 1, 2024 04:39
@rukai rukai requested a review from conorbros March 1, 2024 04:47
@rukai rukai merged commit 4a7003f into shotover:main Mar 4, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants