Redis remove pushed messages #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
redis_remove_pushed_messages
branch
from
b82d02f
to
a65c488
Compare
conorbros
approved these changes
Mar 18, 2024
cjrolo
approved these changes
Mar 18, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites RedisSinkSingle to send pubsub messages through
Transform::transforminstead ofTransform::pushed_messages.In the process we also remove the pubsub logic currently duplicated between RedisSinkSingle and the redis codec. A nice win.
The spawn_read_write_tasks in server.rs is extended to support, forcing the chain to run, in the future I will pull spawn_read_write out of server.rs as it will be used by all sink transforms for creating connections.
I checked for regressions in windsock, since we are making significant changes to our connection logic, and its all clear:
