Remove sasl config #1545
Merged
Remove sasl config #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbros
force-pushed
the
remove-sasl-config
branch
from
ab552d7
to
add090f
Compare
rukai
reviewed
Mar 25, 2024
rukai
reviewed
Mar 25, 2024
rukai
approved these changes
Mar 25, 2024
cjrolo
approved these changes
Mar 25, 2024
conorbros
force-pushed
the
remove-sasl-config
branch
from
42960be
to
e122446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1522
#1513 introduced a config for SASL as a workaround until we arrived at an implementation that dynamically handled both SASL and non-SASL
This PR removes that workaround.