CassandraSinkCluster replace recv with try_recv #1553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps CassandraSinkCluster from recv to try_recv for the performance improvements it brings:
Looks like a large win for connection_count=1
And when comparing against benches without shotover in the loop we can see that shotover is now very close!
connection_count = 1 has shotover lagging behind by about 20-30%
connection_count = 10 has slightly higher throughput for shotover (in reality thats probably just noise)
connection_count = 100 is also pretty much identical.