KafkaSinkCluster: authorize_scram_over_mtls #1605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1600
Possibly useful resources:
This PR introduces a new optional config to
KafkaSinkCluster
:The documentation added in
docs/src/transforms.md
explains what this feature does and why we want it, so please refer to it.In terms of implementation decisions:
I looked into two crates to provide the SCRAM implementation
rsasl
cratesasl
crateIn conclusion the
sasl
crate looked like a clear winner, so I went with it.I've left the hardcoded 4 second delay in, it will be addressed along with caching delegation tokens in a follow up PR: #1618