Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster scram_over_mtls - full integration tests #1651

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Jun 4, 2024

This PR extends the test cases added in #1652
It introduces a very similar case, run on a fresh shotover instance but running the stages of the test in a different order, in an effort to find possible token usage edge cases.

In doing so it uncovered a race condition in shotover.
When parsing metadata responses, we were previously updating the local nodes list only when the node was new globally.
However this is incorrect, we may still need to update the local nodes list even if the node is not new globally.
So this PR fixes this issue by pulling self.update_local_nodes() out of the if new { statement.

I've also left in a debug implementation for KafkaNode since I've found that we often want to be able to include it in temporary debug logs when investigating kafka bugs.

Copy link

codspeed-hq bot commented Jun 4, 2024

CodSpeed Performance Report

Merging #1651 will not alter performance

Comparing rukai:scram_over_mtls_tests (0f3d3a2) with main (796e346)

Summary

✅ 37 untouched benchmarks

@rukai rukai changed the title KafkaSinkCluster scram_over_mtls - thorough integration tests KafkaSinkCluster scram_over_mtls - full integration tests Jun 4, 2024
@rukai rukai force-pushed the scram_over_mtls_tests branch 4 times, most recently from 03007ae to 433c82d Compare June 6, 2024 02:17
@rukai rukai force-pushed the scram_over_mtls_tests branch 4 times, most recently from 7af0a21 to 417fc03 Compare June 11, 2024 07:27
@rukai rukai marked this pull request as ready for review June 11, 2024 10:01
@rukai rukai enabled auto-merge (squash) June 13, 2024 02:21
@rukai rukai merged commit 9f89390 into shotover:main Jun 13, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants