Add integration tests for fetch.min.bytes and fetch.wait.max.ms #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
min_bytes_tests
branch
2 times, most recently
from
0ade477
to
49ae87b
Compare
CodSpeed Performance ReportMerging #1757 will not alter performanceComparing Summary
|
rukai
force-pushed
the
min_bytes_tests
branch
8 times, most recently
from
ed251f1
to
0894590
Compare
rukai
force-pushed
the
min_bytes_tests
branch
from
0894590
to
88022d7
Compare
justinweng-instaclustr
approved these changes
Sep 26, 2024
ronycsdu
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration test cases for
fetch.min.bytesandfetch.wait.max.ms.We will be implementing logic to adhere to these values in #1756 so we want to make sure that we have some coverage of them. This PR can be merged first since we dont have any correctness issues with these values, only performance issues.
Since we have two new fields that we want to be able to configure the consumer with, its time that we refactor
connect_consumerto use the builder pattern instead of creating argument soup.