Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #491 (We now ensure we read a response for every request we send out, which fixes the hang)
Recreates these fixes that were incidentally fixed by https://github.com/shotover/shotover-proxy/pull/645/files :
return Err(anyhow!("encountered error in redis stream: {err:?}"))
I've pulled these fixes out because they are important and the pubsub PR is very complicated and will take a while to review and land.