Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout in RedisSinkSingle #719

Closed
wants to merge 3 commits into from

Conversation

rukai
Copy link
Member

@rukai rukai commented Aug 2, 2022

closes #491 (We now ensure we read a response for every request we send out, which fixes the hang)

Recreates these fixes that were incidentally fixed by https://github.com/shotover/shotover-proxy/pull/645/files :

  • Fix timing issue where only a subset of the responses are returned. (fixed by looping until result.len() < requests_len)
  • Fix errors going unreported and leaving the connection in an invalid state, we now terminate the connection and log an error when an error is encountered return Err(anyhow!("encountered error in redis stream: {err:?}"))

I've pulled these fixes out because they are important and the pubsub PR is very complicated and will take a while to review and land.

@rukai rukai force-pushed the fix_redis_sink_single_timeout branch from c5a1f46 to c5a8515 Compare August 2, 2022 03:05
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

0 benchmark regressed. 1 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/2780017905

  4 (4.00%) high severe
redis/passthrough_set   time:   [176.18 us 176.93 us 177.78 us]
                        thrpt:  [5.6249 Kelem/s 5.6519 Kelem/s 5.6759 Kelem/s]
                 change:
                        time:   [-24.413% -22.478% -20.493%] (p = 0.00 < 0.05)
                        thrpt:  [+25.775% +28.996% +32.299%]
                        Performance has improved.

@rukai
Copy link
Member Author

rukai commented Aug 5, 2022

Superceded by #645

@rukai rukai closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hang in redis_int_tests::basic_driver_tests::test_source_tls_and_single_tls
2 participants