Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cassandra-cluster-tls int test #722

Merged
merged 2 commits into from
Aug 4, 2022
Merged

cassandra-cluster-tls int test #722

merged 2 commits into from
Aug 4, 2022

Conversation

conorbros
Copy link
Member

No description provided.

@conorbros conorbros requested a review from rukai August 3, 2022 08:50
rukai
rukai approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for doing this, it will be good to have the extra int test to develop against.

benbromhead
benbromhead approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@benbromhead benbromhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rukai rukai merged commit ad1e4fe into shotover:main Aug 4, 2022
@conorbros conorbros deleted the cassandra-sink-cluster-tls branch August 4, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@benbromhead benbromhead benbromhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorbros @rukai @benbromhead