Fix another intermittent cluster failure #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
fix_intermittent_failure
branch
from
5c4d0f8
to
0d5ec99
Compare
benbromhead
approved these changes
Aug 9, 2022
XA21X
reviewed
Aug 9, 2022
XA21X
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/shotover/shotover-proxy/runs/7739411831?check_suite_focus=true
This time the problem is in table::test
... and another showed up in udt::test
The problem is because we arent waiting for the cluster to reach schema agreement before running certain commands, so we can fix it by using the SchemaAwaiter like we do in functions::test
Rather than remove another test case from the TLS tests I reintroduced the previously removed functions::test case by adding a new_noop constructor