CassandraSinkCluster query system.local for local node info #735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to the integration test demonstrates the change: we are now representing the entire cluster in the nodes list, previously we only included the 2 peers of the node we are querying but now we include the node itself as well.
Additionally I improved the error handling by:
CassandraOperation::Error
s are now logged - a possible case that could cause that is an auth error which is a realistic case.The old QueryParams values were blindly copy pasted in and on closer inspection they are not very good. e.g. page_size and timestamp should not be set.
I used the QueryParams::default because all of the default values happen to be exactly what we want.