Optimise mpsc tee #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbromhead
reviewed
Nov 23, 2020
| @@ -145,12 +145,11 @@ impl Transform for Tee { | |||
| return match self.behavior { | |||
| ConsistencyBehavior::IGNORE => { | |||
| self.tx | |||
| .send(ChannelMessage::new_with_no_return(m)) | |||
| .try_send(ChannelMessage::new_with_no_return(m)) | |||
There was a problem hiding this comment.
do you want to extend this behaviour to the other modes? E.g. LOG should log to the other channel when try_send fails and FAIL should fail the whole request
| default_topic | ||
| }); | ||
|
|
||
| let built_topics = topics.iter().map(|(k, v)| (k.to_owned(), v.unwrap_or(5))).collect(); |
There was a problem hiding this comment.
you can use into_iter to move ownership of the objects in the iterator into the map. to_owned usually results in a clone.
The compiler should optimise this away, and it doesn't really matter as this is just config loading, but something to keep in mind if you want to get things out of an iterated collection
There was a problem hiding this comment.
righto, i thought there was a better way to do this goo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.