-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdrs-tokio test suite integration #741
Conversation
0c64769
to
70e850b
Compare
Not ready for review yet, just trying to get the CI to run so I can check it's working. |
70e850b
to
83a7810
Compare
This seems stuck, are we pursuing this (or a todo later)? |
e4f7e6f
to
ad8f732
Compare
b487625
to
8d06cb6
Compare
This PR enables us to run There is still some problems running cdrs-tokio on all the tests:
I need to re-enable the collections test before this can be merged. After that, need to decide whether to:
I'm leaning towards merging once cdrs-tokio passes on all the tests. Getting all the setup code for adding new drivers in could be useful though, for example the scylla driver could also be added. |
As long as we have integration test cases running on at least the cassandra_cpp driver and we are happy with the multi-driver abstraction then I am happy to merge. |
9c64228
to
4681688
Compare
The test run time has halved from 40m -> 20m, I think a bunch of tests are no longer running. |
7379af1
to
9de308c
Compare
Fixed the issue with it missing some tests, review can continue now. |
9de308c
to
176c4f1
Compare
3513ab1
to
3efc6bf
Compare
3efc6bf
to
9605d9d
Compare
9605d9d
to
1cda50f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might end up removing the rstest approach later on so that we can reuse Cassandra clusters between tests that have identical Cassandra setups.
The rstest approach is fine for now though, let's land this and iterate further in main.
1cda50f
to
3c2cda9
Compare
3c2cda9
to
160a46e
Compare
No description provided.