Fix a (different) intermittent failure #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbromhead
approved these changes
Aug 14, 2022
conorbros
approved these changes
Aug 15, 2022
rukai
force-pushed
the
fix_different_failure
branch
from
c5284a3
to
d72a093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a lot rarer.
Heres a screenshot of it occuring.
I suspect the difference in error message is caused by the error occurring on a query that the coordinator has routed onto another node rather than just being run locally by the coordinator.
Thats just a guess though and it doesnt really matter the cause, the error can be different sometimes so we just need to change the assert to a contains check rather than an equals check.