Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show filter warning once #761

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Aug 26, 2022

This makes the test logs very noisy, we shouldn't show it for every message. Just once per Wrapper would be enough.

@rukai
Copy link
Member

rukai commented Aug 26, 2022

which test was hitting this problem again?

@rukai
Copy link
Member

rukai commented Aug 26, 2022

To test the effect of this PR run: cargo test redis_int_tests::test_cluster_dr_redis

As currently implemented it doesnt have much of an effect because shown_error isnt persisted across multiple message batches.

I did implement this error! with the intention of it being annoying so that we would prioritize fixing it.
But it is a very tricky problem to solve and we have other priorities right now so I'm not opposed to making it quieter.

@conorbros conorbros requested a review from rukai August 30, 2022 10:37
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@benbromhead benbromhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conorbros conorbros merged commit eb2d8b3 into shotover:main Aug 31, 2022
@conorbros conorbros deleted the test-log-fix branch August 31, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants