Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CassandraSinkCluster fix connecting to non-local clusters #770

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Aug 30, 2022

closes #767

The problem was caused by TcpStream::connect blocking indefinitely when given a meaningless local ip instead of the global ip that we actually meant to give it.
The fix is: when generating the node list we need to query the correct system.local field broadcast_address that gives us the global ip that we actually wanted, instead of listen_address which gives us the local ip.

@github-actions
Copy link

1 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/2953148101

  1 (1.00%) low mild
  5 (5.00%) high mild
  1 (1.00%) high severe
transform/cassandra_request_throttling_unparsed
                        time:   [1.0342 us 1.0408 us 1.0482 us]
                        change: [+22.825% +25.479% +27.819%] (p = 0.00 < 0.05)
                        Performance has regressed.

@conorbros conorbros merged commit 3ca93e7 into shotover:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CassandraSinkCluster - Failure to complete driver initialization when connecting to non-local cluster
3 participants