Cleanup cassandra protocol negotiation #772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error reporting and makes the cassandra protocol implementation easier to understand.
Downgrades the warnings caused by cassandra protocol negotiation to
info!
level.It certainly makes the integration tests quieter, but maybe the slight performance loss of protocol negotiation is worth a warning?
Theres some magic trait type stuff going on here:
In these lines:
We can set any type to be the Error as long as it implements
From<std::io::Error>
.Internally tokio then uses that implementation to generate errors in our type when it hits an
io::Error
while receiving from the TcpStream.So while we never create a
CodecReadError::Io
directly, tokio will return those sometimes when we callFrameRead::next
.