CassandraSinkCluster: Control connection always connects to configured dc/rack #777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #758
The new logic looks like:
This didnt end up cleaning up as much code as I had originally hoped, the system.peers rewriting still needs to perform its own system.local and system.peers queries regardless, but I think it is still the most correct approach.
I think that the consistency of always having our control connection connect to our dc/rack should help avoid some nasty and hard to detect edge cases.