CassandraSinkCluster: return error when system.peers WHERE #779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning an error for WHERE on system.peers makes complete sense to me as we currently make no attempt to handle the WHERE and I havent seen drivers use a WHERE before.
system.local is tricky though, I have seen drivers do redundant WHERE's that always evaluate to true for reasons unknown, so we need a more careful approach there.
Now that we have a third case of
RewriteTableTy
I opted for a little bit of duplication in the rewrite handling to make each specific case easier to reason about.I imagine this error infrastructure will be useful for returning errors in more cases later on, e.g. returning error on tracing tables.