Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CassandraSinkCluster: return error when system.peers WHERE #779

Closed
wants to merge 1 commit into from

Conversation

rukai
Copy link
Member

@rukai rukai commented Sep 1, 2022

Returning an error for WHERE on system.peers makes complete sense to me as we currently make no attempt to handle the WHERE and I havent seen drivers use a WHERE before.
system.local is tricky though, I have seen drivers do redundant WHERE's that always evaluate to true for reasons unknown, so we need a more careful approach there.

Now that we have a third case of RewriteTableTy I opted for a little bit of duplication in the rewrite handling to make each specific case easier to reason about.

I imagine this error infrastructure will be useful for returning errors in more cases later on, e.g. returning error on tracing tables.

@benbromhead
Copy link
Member

What do the java, python, c driver all do with regards to queries with predicates on local and peers? We want these (and other) drivers to just work, so we might have to do the wrong thing to be right in this situation. E.g. just return the table, ignore the where predicates and hope the driver gets what it needs?

@shotover shotover deleted a comment from github-actions bot Sep 1, 2022
@rukai rukai marked this pull request as draft September 15, 2022 05:43
@rukai
Copy link
Member Author

rukai commented Nov 11, 2022

Superseded by #909

@rukai rukai closed this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants