test_cluster_single_rack: duplicate into v3 and v4 variants #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
int_test_cassandra_v4
branch
from
10f4e99
to
4463986
Compare
rukai
force-pushed
the
int_test_cassandra_v4
branch
from
4463986
to
418f369
Compare
|
Happy to merge as is, but I think we should consider looking into seeing if there's a way to use the rstest library for this. Alot of duplicated docker files |
conorbros
approved these changes
Sep 1, 2022
benbromhead
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster_sink_rack_singleis duplicated intocluster_sink_rack_single_v3andcluster_sink_rack_single_v4To support this we split off the version specific parts from
cassandra_int_tests/cluster.rsintocassandra_int_tests/cluster_single_rack_v3.rsandcassandra_int_tests/cluster_single_rack_v4.rsEvery other int test can be swapped over to v4 in a follow up PR