Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused MessageValue variants #788

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Sep 6, 2022

I have vague guesses at what these were for but they are unused so lets get rid of them.

Copy link
Member

@benbromhead benbromhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always add them back in, but the idea was to represent other data types (esp documents... say for mongodb).

@rukai rukai enabled auto-merge (squash) September 8, 2022 02:38
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

1 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/3012197790

�[2m2022-09-08T04:03:44.671312Z�[0m �[31mERROR�[0m �[2mshotover_proxy::server�[0m�[2m:�[0m source CassandraSource encountered an error when flushing the chain for shutdown: Failed to connect to upstream: "127.0.0.1:9043"
cassandra/tls_insert    time:   [1.2105 ms 1.2480 ms 1.2883 ms]
                        thrpt:  [776.21  elem/s 801.29  elem/s 826.09  elem/s]
                 change:
                        time:   [+24.720% +31.848% +38.957%] (p = 0.00 < 0.05)
                        thrpt:  [-28.035% -24.155% -19.820%]
                        Performance has regressed.

@rukai rukai merged commit af2fa3a into shotover:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants