Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message used in the
encode_cassandra_system.local_result
benchmark is taken directly from a real system.local response.After implementing this I realized it was way too much work manually converting the message to the rusty frame types.
So I think we would probably be better off with just taking a raw binary message, and then programmatically decoding it into a frame before the bench runs.
However I've got this now and its fine was just more effort than was needed, so if others are happy to, we can land this and then rewrite to the raw binary approach if we want to add more cases later on.