Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use docker anchors #791

Merged
merged 3 commits into from
Sep 8, 2022
Merged

use docker anchors #791

merged 3 commits into from
Sep 8, 2022

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Sep 7, 2022 •
edited by rukai
Loading

large nit fix

@conorbros conorbros requested a review from rukai September 7, 2022 02:37
@conorbros conorbros changed the title use docker anchor use docker anchors Sep 7, 2022
rukai
rukai approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

I often make mistakes when im quickly testing something where I only update one of the containers, so this is much appreciated.

benbromhead
benbromhead approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@benbromhead benbromhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@rukai rukai enabled auto-merge (squash) September 8, 2022 02:05
@rukai rukai merged commit 10174bf into shotover:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@benbromhead benbromhead benbromhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorbros @rukai @benbromhead