CassandraSinkCluster keyspace based routing - handle use statements #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
handle_use_statements_when_routing
branch
from
0b297cd
to
0dd3abe
Compare
conorbros
reviewed
Sep 16, 2022
rukai
force-pushed
the
handle_use_statements_when_routing
branch
from
37cee7b
to
5180bd5
Compare
benbromhead
approved these changes
Sep 19, 2022
conorbros
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles use statements in every case except one:
usekeyspace is used, this ensures a single source of truth for transforms.The one case we arent handling is prepared statements.
use statements also affect prepared statements, but currently shotover does not support parsing prepared statements so I have just left that functionality as a TODO.
There is a performance concern: calling metadata is currently more expensive than it needs to be due to internally copying the entire message body and then dropping it.
But that can be addressed later on in a follow up PR.
Making this change caused the
.as_raw_bytes()hack to start blowing up due to the message already being parsed, so I also changed all instances of it to just use.metadata()instead.