Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two benefits here:
tracing::error!("look at this {}", message.to_high_level_string())
. In particular I was overwhelmed by all the log noise when investigating the failure on CassandraSinkCluster: topology task now processes events #812In order to allow parsing the message I couldnt implement Display for Message due to needing mutable access, so instead I added a
to_high_level_string
method.While writing the format I wanted to prioritize both terseness and including every underlying field in some way.
To do this I was willing to introduce ambiguity in many places, but that is ok because its a format for humans to read not computers.
Some instances where this came up is:
The result metadata types formatting are not great right now but I want to refactor the underlying types there sometime so not too fussed about that atm.
Many message types are just stubbed to give the standard "{:?}" debug output, I expect we will want to come back and implement those properly later on.
Here is some before and afters:
system.local query/response before:
system.local query/response after:
And a bonus one, that demonstrates multi-row results that I couldnt find a before screenshot for: