CassandraSinkCluster: Fix system.peers rpc_address #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbros
approved these changes
Oct 4, 2022
rukai
force-pushed
the
fix_system_local_rpc_address
branch
from
b20ca76
to
7b7db90
Compare
rukai
force-pushed
the
fix_system_local_rpc_address
branch
from
7b7db90
to
536bf9a
Compare
rukai
changed the title
|
I feel like we should have an integration test that catches this / demonstrates the fix. Or is it the case that our test C* drivers don't hit this edge case? |
|
The integration tests do catch it, we just have to use Result::Any because we dont know which node we are talking to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpc_address is a field in system.peers but not system.peers_v2
Driver's often still use system.peers instead of system.peers_v2 for routing.
So this field turned out to actually be important but we were just setting it to null.
As expected I had to change rpc_address fields in the integration tests.
However I also had to change the system.local listen_address in cluster_multi_rack, I assume that this change is now allowing the driver to properly route between multiple shotover instances resulting in different listen_address values.