Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CassandraSinkCluster: Disallow inserting/removing the nodes list from outside of NodePool #843

Merged
merged 1 commit into from
Oct 6, 2022
Merged

CassandraSinkCluster: Disallow inserting/removing the nodes list from outside of NodePool #843

merged 1 commit into from
Oct 6, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 5, 2022

Better integrates the separately developed abstractions of #831 and #824

@shotover shotover deleted a comment from github-actions bot Oct 5, 2022
conorbros
conorbros approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@conorbros conorbros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think I originally had plans along the lines of the node list being immutable but it's use wasn't clear until your work on 831.

@rukai rukai marked this pull request as ready for review October 5, 2022 07:01
@conorbros conorbros merged commit 96a015c into shotover:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbromhead benbromhead benbromhead approved these changes

@conorbros conorbros conorbros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rukai @benbromhead @conorbros