Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom image for tls cassandra #851

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 11, 2022

Cuts off ~2mins from cassandra_int_tests total runtime. (cuts ~1 min off of 2 integration tests)
also cuts 2min off the total runtime for CI benchmarks (1 TLS bench and every bench is run twice in CI)

Needed to create a separate image as we need to modify the config file to set TLS.

I also noticed the regular image cassandra.yaml had some experimental features enabled so I disabled those.

@rukai rukai force-pushed the speedup_cassandra_tls_containers branch 3 times, most recently from ea246d2 to 9b87f0b Compare October 11, 2022 07:18
@conorbros
Copy link
Member

I thought we just needed to provide the keystore to enable TLS?

@rukai
Copy link
Member Author

rukai commented Oct 11, 2022

image
We also need to set client_encryption_options to enabled

@rukai rukai requested review from conorbros and XA21X October 11, 2022 20:56
@rukai rukai force-pushed the speedup_cassandra_tls_containers branch from 9b87f0b to baf4fa5 Compare October 12, 2022 23:29
@rukai rukai enabled auto-merge (squash) October 13, 2022 00:30
@rukai rukai merged commit b8feea7 into shotover:main Oct 13, 2022
@github-actions
Copy link

0 benchmark regressed. 1 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/3238829362

  1 (1.00%) high mild
cassandra/tls_select    time:   [455.19 us 461.71 us 469.14 us]
                        thrpt:  [2.1316 Kelem/s 2.1659 Kelem/s 2.1969 Kelem/s]
                 change:
                        time:   [-35.075% -33.423% -31.877%] (p = 0.00 < 0.05)
                        thrpt:  [+46.793% +50.201% +54.023%]
                        Performance has improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants