-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and test token aware routing #854
Conversation
b233bb9
to
5293e6e
Compare
a18e19a
to
9f315d9
Compare
bae8e25
to
4b967a0
Compare
This reverts commit c2efee0.
4b967a0
to
4a45eac
Compare
4a45eac
to
54b6d5c
Compare
I removed the bug fix and confirmed that causes the new test case to fail. I also added some debug logs to verify that we were indeed routing to different nodes each time:
The new routing.rs test case takes 84s to run on my machine. With only 800 prepared queries that is 100ms per query, that seemed pretty bad to me? Can we lower the loop to something like |
700c8b2
to
716c6e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on coming up with a way to test that our routing and then figuring out what was wrong with our implementation.
Using tracing to ensure our routing matches that of a known good implementation is really clever!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one - clever!!
Pre-req:
Fixes a bug in token aware routing and tests against the Scylla driver.