CassandraSinkCluster: rewrite rpc_address #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
rewrite_rpc_address
branch
from
c5e84a5
to
fa91521
Compare
rukai
force-pushed
the
rewrite_rpc_address
branch
from
fa91521
to
6ecc16c
Compare
benbromhead
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
cc @XA21X can you double check on the C* driver operation side of this. Sounds right to me
conorbros
approved these changes
Oct 18, 2022
XA21X
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default this field is 0.0.0.0, in that case no mapping is required as 0.0.0.0 is valid no matter what our ip is.
However if a cassandra node does have rpc_address configured properly, then we would be leaking internal cluster ip addresses by not remapping it.
So this PR maps it to shotovers ip address.
Its also worth noting that rpc_address IS the field used to set the address where the client connects to, despite
rpcmaking it sound like it has to do with the old thrift stuff.The old name is just kept for legacy reasons.