New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyspace info for replication factor #895

Merged

rukai merged 13 commits into shotover:main from conorbros:keyspace

Nov 9, 2022

Member

conorbros commented Nov 2, 2022 •

edited

Loading

This PR gets the keyspace metadata from the system_schema.keyspaces table. When a keyspace using NetworkTopologyStrategy we only use the replication factor for the data center the Shotover node is in. Processing schema change events occurs the same as topology change events.

This was referenced Nov 2, 2022

Replica choice bug fix #894

Merged

Token aware routing #840

Closed

conorbros force-pushed the keyspace branch 3 times, most recently from 608cf26 to 3797eac Compare

November 3, 2022 03:50

conorbros marked this pull request as ready for review

November 3, 2022 03:54

conorbros requested a review from rukai

November 3, 2022 03:54

conorbros force-pushed the keyspace branch from 3797eac to 0895985 Compare

November 3, 2022 04:26

conorbros commented

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/node_pool.rs Outdated Show resolved Hide resolved

conorbros commented

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/node_pool.rs Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/token_map.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/token_map.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

conorbros force-pushed the keyspace branch from 0895985 to 40072dd Compare

November 3, 2022 06:41

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/frame/cassandra.rs Outdated Show resolved Hide resolved

conorbros force-pushed the keyspace branch from cf001f9 to 57a5bdf Compare

November 7, 2022 00:56

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/topology.rs Outdated Show resolved Hide resolved


scylla driver tests

329707d

rukai reviewed

View reviewed changes

shotover-proxy/tests/cassandra_int_tests/prepared_statements.rs Outdated Show resolved Hide resolved

conorbros force-pushed the keyspace branch 2 times, most recently from 8bd21d9 to 4e7909f Compare

November 8, 2022 02:05


review feedback

3f2fb2e

shotover deleted a comment from github-actions bot

rukai and others added 8 commits

November 8, 2022 15:35


Merge branch 'main' into scylla-driver-tests

88afab8


keyspace

8c07ab8


better error handling

afc7b5f


review feedback

e78fe09


review feedback

93ce81a


review feedback

d513d7b


review feedback

3c7c6a5


review feedback

3d51ea9

conorbros force-pushed the keyspace branch from 4e7909f to 3d51ea9 Compare

November 8, 2022 05:10

github-actions bot commented Nov 8, 2022

1 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/3416555158

  3 (3.00%) high severe
cassandra/tls_insert    time:   [1.0836 ms 1.1278 ms 1.1764 ms]
                        thrpt:  [850.03  elem/s 886.67  elem/s 922.86  elem/s]
                 change:
                        time:   [+20.105% +25.844% +31.985%] (p = 0.00 < 0.05)
                        thrpt:  [-24.234% -20.537% -16.740%]
                        Performance has regressed.

benbromhead approved these changes

View reviewed changes


Merge branch 'main' into keyspace

493e239

rukai reviewed

View reviewed changes

shotover-proxy/tests/helpers/cassandra.rs Outdated Show resolved Hide resolved


Merge branch 'main' into keyspace

a49c4b1

conorbros force-pushed the keyspace branch from 032404f to a49c4b1 Compare

November 9, 2022 00:53

rukai reviewed

View reviewed changes

shotover-proxy/src/transforms/cassandra/sink_cluster/node_pool.rs Outdated Show resolved Hide resolved

rukai reviewed

View reviewed changes

shotover-proxy/tests/cassandra_int_tests/prepared_statements.rs Show resolved Hide resolved


review feedback

741d1c9

rukai approved these changes

View reviewed changes

Member

rukai left a comment

LGTM

rukai merged commit 5e2c153 into shotover:main

conorbros deleted the keyspace branch

November 9, 2022 05:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment