Add verify_hostname tls flag #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
add_verify_hostname_flag
branch
2 times, most recently
from
572078f
to
b8f7c92
Compare
rukai
force-pushed
the
add_verify_hostname_flag
branch
from
b8f7c92
to
07d9574
Compare
|
Actually having tried it just now in our integration tests, redis doesnt seem to have any hard requirement forcing verify_hostname being disabled. |
rukai
force-pushed
the
add_verify_hostname_flag
branch
from
f9af296
to
23ec995
Compare
conorbros
approved these changes
Nov 2, 2022
XA21X
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis does not allow verify_hostname at all.Cassandra does allow verify_hostname but some users may wish to disable it.
To support both of these uses an optional verify_hostname field is added to the tls connector config.
It has the safest default value for each protocol and extra validation to ensure that redis cannot be configured to use a setting that it is not compatible with.
Redis and cassandra both support verify_hostname but some users may wish to disable it if their setup does not permit it.