Make connect timeout configurable #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
configurable_connect_timeout
branch
from
c6c6363
to
b0d7814
Compare
rukai
force-pushed
the
configurable_connect_timeout
branch
2 times, most recently
from
44a5738
to
be0cecf
Compare
rukai
force-pushed
the
configurable_connect_timeout
branch
from
be0cecf
to
cc70b82
Compare
benbromhead
approved these changes
Nov 8, 2022
conorbros
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect_timeout_ms is a mandatory config option to make it explicit in the config what the connect timeout is and make the docs easier to read.
This wont have any extra cost to the user because they are expected to copy/paste in the example config from the docs anyway.